Skip to content

api: add OOB BackendUtilization - #9400

Merged
jukie merged 13 commits into
envoyproxy:mainfrom
jukie:backendutilization-oob
Jul 29, 2026
Merged

api: add OOB BackendUtilization#9400
jukie merged 13 commits into
envoyproxy:mainfrom
jukie:backendutilization-oob

Conversation

@jukie

@jukie jukie commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds API fields to support ORCA Out-of-Band reporting

Which issue(s) this PR fixes:

xRef #9401

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit e474be6
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a6a1e6a08ae490008b7358d
😎 Deploy Preview https://deploy-preview-9400--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jukie
jukie marked this pull request as ready for review July 1, 2026 18:44
@jukie
jukie requested a review from a team as a code owner July 1, 2026 18:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0e29a4678

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go Outdated
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.68%. Comparing base (ddf2fc4) to head (e474be6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9400      +/-   ##
==========================================
+ Coverage   75.67%   75.68%   +0.01%     
==========================================
  Files         254      254              
  Lines       41946    42110     +164     
==========================================
+ Hits        31744    31873     +129     
- Misses       8071     8092      +21     
- Partials     2131     2145      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5923722feb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go Outdated
@jukie jukie added this to the v1.9.0-rc.1 Release milestone Jul 1, 2026
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie requested a review from a team July 1, 2026 19:10
Comment thread api/v1alpha1/loadbalancer_types.go Outdated
jukie and others added 2 commits July 27, 2026 10:23
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie requested review from a team and arkodg July 27, 2026 16:46
arkodg
arkodg previously approved these changes Jul 28, 2026

@arkodg arkodg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg
arkodg requested review from a team July 28, 2026 16:35
@jukie

jukie commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Comment thread api/v1alpha1/loadbalancer_types.go Outdated
// +kubebuilder:validation:Maximum=65535
// +optional
// +notImplementedHide
Port *uint32 `json:"port,omitempty"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use gwapiv1.PortNumber

@jukie jukie Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaohuabing I ended up reverting this back to *int32. We only use it in one other place currently vs int32 for 8 other port fields and it breaks the kubebuilder bounds setup.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this but will ping you on the implementation PR in case you'd still prefer to use PortNumber

zirain
zirain previously approved these changes Jul 29, 2026
@zirain

zirain commented Jul 29, 2026

Copy link
Copy Markdown
Member

/retest

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie dismissed stale reviews from zirain and arkodg via aaa35b4 July 29, 2026 02:14
@jukie
jukie requested review from arkodg, zhaohuabing and zirain July 29, 2026 02:14
@jukie

jukie commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aaa35b4427

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/content/en/latest/tasks/traffic/backend-utilization.md Outdated
Comment thread site/content/en/latest/tasks/traffic/backend-utilization.md Outdated
Comment thread api/v1alpha1/loadbalancer_types.go Outdated
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34ee3ebcbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go
Comment thread site/content/en/latest/tasks/traffic/backend-utilization.md
cnvergence
cnvergence previously approved these changes Jul 29, 2026
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e474be666f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go
@kkk777-7

Copy link
Copy Markdown
Member

LGTM!

@jukie
jukie merged commit b499c27 into envoyproxy:main Jul 29, 2026
67 of 70 checks passed
@jukie
jukie deleted the backendutilization-oob branch July 29, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants